Motivation

When using ethers_solc to compile contracts, remappings have an issue with the hardcoded specific fix for an openzeppelin contracts issue.

I'm not very familiar with the issue described in the doc comments, but it is erroring in situations where it shouldn't be applicable.

// we handle the edge case where the path of a remapping ends with "contracts"
// (`<name>/=.../contracts`) and the stripped import also starts with
// `contracts`
if let Ok(adjusted_import) = stripped_import.strip_prefix("contracts/") {
    if r.path.ends_with("contracts/") && !lib_path.exists() {
        return Path::new(&r.path).join(adjusted_import)
    }
}

Problematic setup

Example import in sol file:

import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";

Example remapping:

@openzeppelin/=lib/openzeppelin-contracts/

in this case, the path of the remapping ends in "contracts/" (lib/openzeppelin-contracts/) and the stripped import also starts with "contracts" (contracts/utils/math/Math.sol).

this makes the resolver look at:
lib/openzeppelin-contracts/utils/math/Math.sol
when it should instead look at:
lib/openzeppelin-contracts/contracts/utils/math/Math.sol

Solution

Stripping based on .ends_with("contracts/") isn't precise. Better suited for issue regarding the comment is .ends_with("/contracts/").

In this instance, the remapping correctly would not get flagged, as it is does not end with "/contracts/" (lib/openzeppelin-contracts/).